Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke _member_ role requirement #37

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Nuke _member_ role requirement #37

merged 1 commit into from
Jul 22, 2024

Conversation

yankcrime
Copy link
Member

@yankcrime yankcrime commented Jul 19, 2024

The _member_ role is a vestige from OpenStack days of yore and no longer exists on recent versions by default. Do as the TODO suggests and remove it.

@yankcrime yankcrime requested a review from spjmurray July 19, 2024 16:45
The _member_ role is a vestige from OpenStack days of yore and no longer
exists on recent versions by default.  Do as the TODO suggests and
remove it.
Copy link
Member

@spjmurray spjmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, making me update my staging configuration are you... let me test you haven't broken it for me first.

@yankcrime
Copy link
Member Author

If it's broke then it's because of Sausage Cloud's policies that need bringing into line - let me know how you fare.

@spjmurray
Copy link
Member

Okay so, as expected, provisioning with the new defaults results in:

{"ts":1721636294055.5776,"caller":"controller/controller.go:329","msg":"Reconciler error","controller":"openstackcluster","controllerGroup":"infrastructure.cluster.x-k8s.io","controllerKind":"OpenStackCluster","OpenStackCluster":{"name":"cluster-cd0eae95","namespace":"f8cdef7d-d5dc-41a3-94ec-2b30802b70ef"},"namespace":"f8cdef7d-d5dc-41a3-94ec-2b30802b70ef","name":"cluster-cd0eae95","reconcileID":"6e360044-5b83-4907-91c1-34f48d568cb1","err":"failed to reconcile load balancer: Request forbidden: [GET https://compute.sausage.cloud:9876/v2.0/lbaas/loadbalancers?name=k8s-clusterapi-cluster-f8cdef7d-d5dc-41a3-94ec-2b30802b70ef-cluster-cd0eae95-kubeapi], error message: {\"faultcode\": \"Client\", \"faultstring\": \"Policy does not allow this request to be performed.\", \"debuginfo\": null}"}

And trying to delete the cluster leads to a deadlock as it cannot read loadbalancers to delete loadbalancers 😸

Setting to the following restores functionality (and actually tests it works):

regions:
- name: gb-north-1
  provider: openstack
  openstack:
    endpoint: https://compute.sausage.cloud:5000
    serviceAccountSecret:
      name: gb-north-1-credentials
    identity:
      clusterRoles:
      - _member_
      - member
      - load-balancer_member

@spjmurray spjmurray merged commit 2ab96d6 into main Jul 22, 2024
2 checks passed
@spjmurray spjmurray deleted the nuke_member branch July 22, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants